Refactor ASAv to use scrapli to send commands #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jmreicha do you mind to add support for startup config? you can take a look @ the other cat8k/9k or xrv9k vrnetlab implementations for this. |
Author
|
Yep I will take a look! |
Author
|
Hey @kaelemc PR updated. Take a look and let me know if that will work, it seems pretty straightforward but may be missing something. |
Member
|
Thanks @jmreicha |
Member
|
thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the ASAv bootstrap configuration logic to use the Scrapli library for device interaction, replacing the previous manual prompt handling and command writing.
This brings the configuration more inline with other existing configs to improve maintainability and make future changes easier.