Report ambiguous using column MySQL error

src/QueryReflection/BasePdoQueryReflector.php

@@ -34,6 +34,8 @@ abstract class BasePdoQueryReflector implements QueryReflector, RecordingReflect
 
     private const MYSQL_UNKNOWN_TABLE = '42S02';
 
+    private const MYSQL_INTEGRITY_CONSTRAINT_VIOLATION = '23000';
+
     private const PDO_SYNTAX_ERROR_CODES = [
         self::MYSQL_SYNTAX_ERROR_CODE,
         self::PSQL_SYNTAX_ERROR,
@@ -48,6 +50,7 @@ abstract class BasePdoQueryReflector implements QueryReflector, RecordingReflect
         self::MYSQL_SYNTAX_ERROR_CODE,
         self::MYSQL_UNKNOWN_COLUMN_IN_FIELDLIST,
         self::MYSQL_UNKNOWN_TABLE,
+        self::MYSQL_INTEGRITY_CONSTRAINT_VIOLATION,
     ];
 
     protected const MAX_CACHE_SIZE = 50;

src/QueryReflection/MysqliQueryReflector.php

@@ -21,6 +21,8 @@ final class MysqliQueryReflector implements QueryReflector, RecordingReflector
 
     private const MYSQL_UNKNOWN_COLUMN_IN_FIELDLIST = 1054;
 
+    private const MYSQL_AMBIGUOUS_COLUMN_IN_FROM_CLAUSE = 1052;
+
     public const MYSQL_UNKNOWN_TABLE = 1146;
 
     private const MYSQL_INCORRECT_TABLE = 1103;
@@ -33,6 +35,7 @@ final class MysqliQueryReflector implements QueryReflector, RecordingReflector
     private const MYSQL_ERROR_CODES = [
         self::MYSQL_SYNTAX_ERROR_CODE,
         self::MYSQL_UNKNOWN_COLUMN_IN_FIELDLIST,
+        self::MYSQL_AMBIGUOUS_COLUMN_IN_FROM_CLAUSE,
         self::MYSQL_UNKNOWN_TABLE,
         self::MYSQL_INCORRECT_TABLE,
     ];

tests/rules/SyntaxErrorInPreparedStatementMethodRuleTest.php

@@ -268,6 +268,26 @@ public function testSyntaxErrorInQueryRule(): void
         $this->analyse([__DIR__ . '/data/syntax-error-in-prepared-statement.php'], $expectedErrors);
     }
 
+    public function test_prepared_statement_method_reports_ambiguous_using_column(): void
+    {
+        if (MysqliQueryReflector::NAME === getenv('DBA_REFLECTOR')) {
+            if ('mariadb' === $_ENV['DBA_PLATFORM']) {
+                $expectedError = "Query error: Column 'adaid' in FROM is ambiguous (1052).";
+            } else {
+                $expectedError = "Query error: Column 'adaid' in from clause is ambiguous (1052).";
+            }
+        } elseif (PdoMysqlQueryReflector::NAME === getenv('DBA_REFLECTOR')) {
+            $expectedError = "Query error: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'adaid' in from clause is ambiguous (23000).";
+        } else {
+            self::markTestSkipped('This regression only applies to MySQL reflectors.');
+        }
+
+        $this->analyse(
+            [__DIR__ . '/data/ambiguous-using-column.php'],
+            [[$expectedError, 11]],
+        );
+    }
+
     public function testBug94()
     {
         if (MysqliQueryReflector::NAME === getenv('DBA_REFLECTOR')) {

tests/rules/data/ambiguous-using-column.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace AmbiguousUsingColumnRuleTest;
+
+use staabm\PHPStanDba\Tests\Fixture\Connection;
+
+class Foo
+{
+    public function preparedStatement(Connection $connection): void
+    {
+        $connection->preparedQuery(
+            'SELECT first.adaid
+             FROM ada first
+             JOIN ada second ON second.adaid = first.adaid
+             JOIN ada third USING(adaid)',
+            [],
+        );
+    }
+}