Skip to content

Add renderer surface crash breadcrumbs#6445

Draft
brennanb2025 wants to merge 3 commits into
mainfrom
brennanb2025/blank-window-diagnostics
Draft

Add renderer surface crash breadcrumbs#6445
brennanb2025 wants to merge 3 commits into
mainfrom
brennanb2025/blank-window-diagnostics

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

Summary

  • Add a lightweight renderer_surface crash breadcrumb at startup and every 60s.
  • Capture document/window/root surface state useful for blank-window triage: visibility, focus, viewport size, root/body dimensions, root child count, and root/body background/display/visibility.
  • Dispose the new interval with the existing renderer crash diagnostics cleanup.

Tests

  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/lib/crash-diagnostics.test.ts
  • pnpm exec oxlint src\renderer\src\lib\crash-diagnostics.ts src\renderer\src\lib\crash-diagnostics.test.ts
  • pnpm run typecheck
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dd29b592-af0d-4f6b-b1fd-9558b620290d

📥 Commits

Reviewing files that changed from the base of the PR and between 89f3387 and 5344c72.

📒 Files selected for processing (2)
  • src/renderer/src/lib/crash-diagnostics.test.ts
  • src/renderer/src/lib/crash-diagnostics.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/renderer/src/lib/crash-diagnostics.ts
  • src/renderer/src/lib/crash-diagnostics.test.ts

📝 Walkthrough

Walkthrough

The renderer crash diagnostics module now records a new renderer_surface breadcrumb at startup and on a repeating interval, using DOM and viewport state when available. It stores and clears a separate interval handle during disposal. The renderer crash diagnostics test fixture was updated to mock additional window and document state, validate the new breadcrumb payload, and assert the diagnostic interval is cleared.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary and tests, but omits required Screenshots, AI Review Report, Security Audit, and Notes sections. Add all template sections, including a screenshots/no-visual-change note, AI review with cross-platform checks, a security audit, and any platform-specific notes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding renderer surface crash breadcrumbs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1e7ff45c-34e1-449f-9c2e-ffb10e66321d

📥 Commits

Reviewing files that changed from the base of the PR and between d188e7d and 0c767a8.

📒 Files selected for processing (2)
  • src/renderer/src/lib/crash-diagnostics.test.ts
  • src/renderer/src/lib/crash-diagnostics.ts

Comment thread src/renderer/src/lib/crash-diagnostics.ts
@brennanb2025 brennanb2025 marked this pull request as draft June 27, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants