Skip to content

Restore agent sessions by dragging the session row#6463

Merged
OrcaWin merged 1 commit into
mainfrom
brennanb2025/bug-the-new-feature-for-restoring-agent-sessions
Jun 28, 2026
Merged

Restore agent sessions by dragging the session row#6463
OrcaWin merged 1 commit into
mainfrom
brennanb2025/bug-the-new-feature-for-restoring-agent-sessions

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

Summary

  • Make AI Vault session rows draggable so dragging from the visible session text starts the restore drag instead of selecting text.
  • Keep the existing grip handle as the explicit affordance.
  • Guard nested action controls so dragging from resume/more/jump/toggle buttons does not inherit the row restore drag.

Review

  • Two quick independent review passes ran.
  • Finding fixed: nested action buttons could inherit the row drag; added data-ai-vault-session-actions/data-ai-vault-session-drag-handle guard.
  • Follow-up finding fixed: SVG icon targets needed Element rather than HTMLElement for closest() checks.

Validation

  • pnpm exec oxlint src/renderer/src/components/right-sidebar/AiVaultSessionRow.tsx src/renderer/src/components/right-sidebar/SessionRowTrailingActions.tsx
  • pnpm run typecheck:web
  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/lib/ai-vault-session-drag.test.ts src/renderer/src/lib/launch-ai-vault-session.test.ts
  • Electron smoke on this worktree via CDP:
    • verified attached app identity matched this branch
    • dragging visible AI Vault session row text produced application/x-orca-ai-vault-session, showed the drop overlay, dropped onto the pane, and queued a new tab
    • dragging from the resume action produced no session drag payload, no overlay, and no extra tab

Notes

  • Scratch screenshot and temporary transcript fixture were removed before commit.
  • SSH/non-local behavior is unchanged: this only changes the renderer drag source before existing drop target checks run.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7ebb2e48-31c0-4474-bd7b-71772ef47286

📥 Commits

Reviewing files that changed from the base of the PR and between 033b016 and 527b9d5.

📒 Files selected for processing (2)
  • src/renderer/src/components/right-sidebar/AiVaultSessionRow.tsx
  • src/renderer/src/components/right-sidebar/SessionRowTrailingActions.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/renderer/src/components/right-sidebar/SessionRowTrailingActions.tsx
  • src/renderer/src/components/right-sidebar/AiVaultSessionRow.tsx

📝 Walkthrough

Walkthrough

The session row drag handling now spans both the row and trailing actions UI. The trailing actions component removes drag-handle wiring and adds a DOM marker for the actions container. The row component now uses an HTMLElement drag event, filters drag starts based on that marker, makes the row draggable when resume is enabled, wires drag start, and dispatches a drag-end event on drag end.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change and validation, but it omits required template sections like Screenshots, Testing checklist, AI Review Report, and Security Audit. Add the missing template sections, including screenshots or "No visual change", a full testing checklist, AI Review Report with cross-platform coverage, and a Security Audit.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main user-visible change: restoring agent sessions by dragging the session row.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025 brennanb2025 force-pushed the brennanb2025/bug-the-new-feature-for-restoring-agent-sessions branch from c846236 to 033b016 Compare June 27, 2026 02:32

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c1cc6861-89fa-4016-9c3f-d573c5dd6333

📥 Commits

Reviewing files that changed from the base of the PR and between c846236 and 033b016.

📒 Files selected for processing (2)
  • src/renderer/src/components/right-sidebar/AiVaultSessionRow.tsx
  • src/renderer/src/components/right-sidebar/SessionRowTrailingActions.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/components/right-sidebar/AiVaultSessionRow.tsx

@brennanb2025 brennanb2025 force-pushed the brennanb2025/bug-the-new-feature-for-restoring-agent-sessions branch from 033b016 to 527b9d5 Compare June 28, 2026 18:40
@OrcaWin OrcaWin merged commit d6f3f51 into main Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants