Skip to content

Expose Markdown doc-link color variable#6477

Open
andrewroxby wants to merge 2 commits into
stablyai:mainfrom
andrewroxby:fix/markdown-doc-link-color-vars
Open

Expose Markdown doc-link color variable#6477
andrewroxby wants to merge 2 commits into
stablyai:mainfrom
andrewroxby:fix/markdown-doc-link-color-vars

Conversation

@andrewroxby

Copy link
Copy Markdown

Summary

  • Add --markdown-doc-link-color for Markdown document-link styling.
  • Apply it across rich Markdown editing, Markdown preview, and source-mode doc-link decorations.
  • Preserve the existing default colors while allowing themes or PKM-style setups to customize wikilink/doc-link color consistently.

Screenshots

No visual change by default. This preserves the existing doc-link colors and exposes the color as a theme variable.

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test
    • Not run; CSS-only change.
  • pnpm build
  • No dedicated tests added; this is a CSS token/style plumbing change with unchanged default visual output.

AI Review Report

Codex and Claude reviewed the change for token placement, default visual preservation, hover behavior, and cross-surface consistency.

Claude flagged that an earlier version's underline decoration variable would have suppressed Markdown preview hover behavior. I did not keep that approach; the final patch exposes only the doc-link color variable and leaves existing underline decoration/hover behavior intact.

The review also checked cross-platform compatibility for macOS, Linux, and Windows: this change is CSS-only and does not touch shortcuts, labels, file paths, shell behavior, IPC, Electron platform branches, SSH/runtime behavior, or provider-specific behavior.

Security Audit

No input handling, command execution, path handling, auth, secrets, dependencies, IPC, or network behavior changed. This is CSS-only.

A secrets pass over added CSS lines found no concerning credentials, tokens, private keys, or infrastructure identifiers.

Notes

This exposes a small styling hook for PKM-style Markdown workflows without changing default rendering behavior.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 76530cfd-2702-4cbc-a681-fe8073f408e2

📥 Commits

Reviewing files that changed from the base of the PR and between 0b625bd and 242ab04.

📒 Files selected for processing (1)
  • src/renderer/src/assets/markdown-preview.css
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/assets/markdown-preview.css

📝 Walkthrough

Walkthrough

Added a shared --markdown-doc-link-color CSS variable to light and dark theme definitions in main.css, and updated Monaco, markdown preview, and rich markdown editor doc-link styles to use that variable instead of hardcoded color values.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: exposing a Markdown doc-link color variable.
Description check ✅ Passed The description matches the required template and includes summary, screenshots, testing, review, security, and notes sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b3f05198-6fea-4e82-8393-63b917b90060

📥 Commits

Reviewing files that changed from the base of the PR and between 360ce67 and 0b625bd.

📒 Files selected for processing (3)
  • src/renderer/src/assets/main.css
  • src/renderer/src/assets/markdown-preview.css
  • src/renderer/src/assets/rich-markdown-editor.css

Comment thread src/renderer/src/assets/markdown-preview.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant