Expose Markdown doc-link color variable#6477
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a shared 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b3f05198-6fea-4e82-8393-63b917b90060
📒 Files selected for processing (3)
src/renderer/src/assets/main.csssrc/renderer/src/assets/markdown-preview.csssrc/renderer/src/assets/rich-markdown-editor.css
Summary
--markdown-doc-link-colorfor Markdown document-link styling.Screenshots
No visual change by default. This preserves the existing doc-link colors and exposes the color as a theme variable.
Testing
pnpm lintpnpm typecheckpnpm testpnpm buildAI Review Report
Codex and Claude reviewed the change for token placement, default visual preservation, hover behavior, and cross-surface consistency.
Claude flagged that an earlier version's underline decoration variable would have suppressed Markdown preview hover behavior. I did not keep that approach; the final patch exposes only the doc-link color variable and leaves existing underline decoration/hover behavior intact.
The review also checked cross-platform compatibility for macOS, Linux, and Windows: this change is CSS-only and does not touch shortcuts, labels, file paths, shell behavior, IPC, Electron platform branches, SSH/runtime behavior, or provider-specific behavior.
Security Audit
No input handling, command execution, path handling, auth, secrets, dependencies, IPC, or network behavior changed. This is CSS-only.
A secrets pass over added CSS lines found no concerning credentials, tokens, private keys, or infrastructure identifiers.
Notes
This exposes a small styling hook for PKM-style Markdown workflows without changing default rendering behavior.