feat(vmcp): log active sessions on creation, expiry, and periodically

[yrobla]

Log session lifecycle events and periodic active session counts for operational debugging and compliance auditing when sessionManagementV2 is enabled.

Changes

• Manager.CreateSession(): upgraded log to Info with session ID, backend count, and backend names
• Manager.Terminate(): log Info with session ID and backend count when a MultiSession expires; separate log for placeholder termination
• Manager.StartPeriodicLogging(ctx, interval): new method that starts a background goroutine logging active session counts every minute
• Manager.logActiveSessions(): internal helper that iterates sessions via Range(), aggregates per-backend session counts, and logs a summary; logs a one-time warning when distributed storage makes enumeration unavailable
• Server.Start(): calls StartPeriodicLogging when SessionManagementV2 is enabled

Removed

• /status endpoint session fields (Sessions, SessionsStatus, BackendUsage) — session data is now surfaced through logs only
• ListActiveSessions() from SessionManager interface

Closes: #3876

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00fd4857c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Adds session visibility to the vMCP /status endpoint to support operational debugging and compliance auditing when SessionManagementV2 is enabled.

Changes:

• Extend /status response schema to optionally include active vMCP sessions and backend session ID mappings.
• Add ListActiveSessions() to the session manager and expose the data through buildStatusResponse.
• Add unit tests for ListActiveSessions() behavior and a regression test that sessions is omitted when V2 is disabled.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/vmcp/server/status.go	Adds optional sessions block to /status when SessionManagementV2 is enabled.
pkg/vmcp/server/status_test.go	Updates status response test DTOs; adds tests for sessions omission and backend field redaction.
pkg/vmcp/server/sessionmanager/session_manager.go	Introduces SessionInfo and implements ListActiveSessions().
pkg/vmcp/server/sessionmanager/list_sessions_test.go	Adds tests for listing behavior across empty, placeholder-only, and populated stores.
pkg/vmcp/server/session_manager_interface.go	Extends the SessionManager interface with ListActiveSessions().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 28.12500% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.63%. Comparing base (0791876) to head (3ad3eae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/vmcp/server/sessionmanager/session_manager.go	33.96%	35 Missing ⚠️
pkg/vmcp/server/server.go	0.00%	7 Missing and 1 partial ⚠️
pkg/transport/session/manager.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4019   +/-   ##
=======================================
  Coverage   68.62%   68.63%           
=======================================
  Files         445      445           
  Lines       45374    45426   +52     
=======================================
+ Hits        31140    31178   +38     
- Misses      11827    11843   +16     
+ Partials     2407     2405    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jerm-dro]

Is this change really necessary? I get that it'd be nice to have visibility into active sessions, but exposing an endpoint seems heavy-handed. Alternative approaches:

• periodically log all the active sessions in memory
• log sessions as they are created and expired

What do you think?

[yrobla]

Is this change really necessary? I get that it'd be nice to have visibility into active sessions, but exposing an endpoint seems heavy-handed. Alternative approaches:

• periodically log all the active sessions in memory
• log sessions as they are created and expired

What do you think?

ok this task came generated by claude, based on the rfc. A bit overkill, i agree. So i modified the issue to log content, as you were saying, and i modified the pr.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.