-
Notifications
You must be signed in to change notification settings - Fork 723
refactor: make clarity-cli to use clap #6720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make clarity-cli to use clap #6720
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (77.18%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6720 +/- ##
===========================================
- Coverage 78.18% 77.18% -1.00%
===========================================
Files 580 580
Lines 361096 361230 +134
===========================================
- Hits 282312 278807 -3505
- Misses 78784 82423 +3639
... and 102 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
stacks-core/contrib/clarity-cli/src/lib.rs Lines 438 to 493 in 90033c3
I noticed that I think we could either remove What do you think? If it makese sense, I'd tackle this in a separate PR. |
brice-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. Just a couple minor comments.
brice-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4538155
Description
Refactors the clarity-cli command-line interface to use
clapfor argument parsing, replacing the previous manual argument handling.Applicable issues
clarity-clito useclap#6671Additional info (benefits, drawbacks, caveats)
Benefits:
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo