-
Notifications
You must be signed in to change notification settings - Fork 723
fix: don't resend block acceptance if already sent #6750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't resend block acceptance if already sent #6750
Conversation
This allows us to differentiate between a signer that has sent a pre-commit and that has sent its approval.
|
It turns out this is not as simple as I hoped. |
This allows the signer to differentiate between a block that it has pre-committed to and one that it has actually signed. Fixes: stacks-network#6743
5cddcc4 to
143fa6d
Compare
This just removes an unexpected warn in test logs.
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (77.63%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6750 +/- ##
===========================================
- Coverage 77.90% 77.63% -0.27%
===========================================
Files 580 580
Lines 361187 361131 -56
===========================================
- Hits 281374 280371 -1003
- Misses 79813 80760 +947
... and 86 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
b1c0de6
The signer is currently sending an approval for every pre-commit that it receives after reaching the threshold weight. This change just makes sure it only sends its approval when it first reaches that threshold, and then ignores the rest of the pre-commits.