Skip to content

Conversation

@hstove-stacks
Copy link
Contributor

I recently added 2 new fields to the gettransaction RPC endpoint, but I forgot to add them to the OpenAPI Schema.

brice-stacks
brice-stacks previously approved these changes Dec 10, 2025
wileyj
wileyj previously approved these changes Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (e3afd65) to head (e1ea2a7).
⚠️ Report is 32 commits behind head on develop.

❌ Your project check has failed because the head coverage (76.96%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6753      +/-   ##
===========================================
+ Coverage    73.03%   76.96%   +3.93%     
===========================================
  Files          580      580              
  Lines       360229   361187     +958     
===========================================
+ Hits        263086   277982   +14896     
+ Misses       97143    83205   -13938     

see 294 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3afd65...e1ea2a7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hstove-stacks
Copy link
Contributor Author

@brice-stacks @wileyj mind re-reviewing? I was using nullable: true, when it should have been type: [number, "null"]

@wileyj
Copy link
Collaborator

wileyj commented Dec 10, 2025

@brice-stacks @wileyj mind re-reviewing? I was using nullable: true, when it should have been type: [number, "null"]

sure! i thought nullable looked odd, but we do use it elsewhere so it seemed fine.

wileyj
wileyj previously approved these changes Dec 10, 2025
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wileyj
wileyj previously approved these changes Dec 11, 2025
brice-stacks
brice-stacks previously approved these changes Dec 11, 2025
@hstove-stacks hstove-stacks added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@wileyj wileyj added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@hstove-stacks hstove-stacks added this pull request to the merge queue Dec 12, 2025
Merged via the queue into stacks-network:develop with commit 7532136 Dec 12, 2025
52 of 55 checks passed
@hstove-stacks hstove-stacks deleted the fix/openapi-gettransaction-schema branch December 12, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants