FIX: streamify was appending StatusStreamingCallback directly to the shared settings.callbacks list #9073
+96
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glesperance
changed the title
glesperance
force-pushed
the
fix/streamify-callbacks-settings-leak
branch
from
e7a8f45 to
2497b19
Compare
Collaborator
chenmoneygithub
left a comment
chenmoneygithub
left a comment
There was a problem hiding this comment.
Thanks for spotting the bug and putting up the PR!
| program = asyncify(program) | ||
|
|
||
| callbacks = settings.callbacks | ||
| callbacks = deepcopy(settings.callbacks) |
Collaborator
There was a problem hiding this comment.
I am concerned about how robust this line is, since there are many cases where deepcopy could fail. Maybe we should just do a shallow copy and use dspy.context(callbacks=callbacks) instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix streaming status message callback mutation
Bug
streamifywas appendingStatusStreamingCallbackdirectly to the sharedsettings.callbackslist.That list was mutated in place and reused across calls, callbacks (and their status message providers) leaked between different
dspy.streamify(...)invocations.Fix
Each call to
streamifynow works on an isolated callback list by copying the global callbacks before modification.This prevents callback leakage between programs, ensures that custom status message providers only affect the specific program they are passed to, and restores the correct, deterministic status message behavior required by the tests.