Skip to content

Drop the 0.12 compatibility - #79

Closed
Bobowski wants to merge 1 commit into
event-labelsfrom
drop-012-compat
Closed

Bobowski wants to merge 1 commit into
event-labelsfrom
drop-012-compat

Conversation

@Bobowski

@Bobowski Bobowski commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Intent

Remove the 0.12 compatibility in 0.14. Source: the user. Keep this pull request open until the 0.14 release.

Found

Yard 0.13 reads two 0.12 forms:

  • An app record with an image or a URL in runs. 0.13.1 writes each such record in the new form when Yard starts.
  • The deploy labels sha and previous. Each deploy writes the new labels, and after Read the 0.13 labels in the deploy rows of yard events #78 one function reads them: status.labels_plan.

Changed

  • _read_app no longer moves runs into image or compose_url. Store.open no longer rewrites records.
  • labels_plan reads only the 0.13 keys. A deploy container with only sha counts as no plan, so the next check deploys the app once.
  • The tests for the 0.12 forms are gone. One test keeps the rule: a record with no revision or no kind has no plan.
  • The changelog says to upgrade a 0.12 host through 0.13.2 first.

Order

  1. Merge Read the 0.13 labels in the deploy rows of yard events #78 and release 0.13.2. GitHub then moves this pull request onto main.
  2. Rebase this branch: the changelog entry of Read the 0.13 labels in the deploy rows of yard events #78 moves under 0.13.2.
  3. Merge this pull request with the 0.14 release.

Proof

just check
522 passed

🤖 Generated with Claude Code

@Bobowski
Bobowski deleted the branch event-labels November 6, 2026 11:29
@Bobowski Bobowski closed this Nov 6, 2026
Bobowski added a commit that referenced this pull request Nov 6, 2026
## Intent

Remove the 0.12 compatibility for 0.14. Source: the user. This replaces
#79, which GitHub closed when its base branch went away.

## Found

Yard 0.13 reads two 0.12 forms:

- An app record with an image or a URL in `runs`. 0.13.1 writes each
such record in the new form when Yard starts.
- The deploy labels `sha` and `previous`. Each deploy writes the new
labels, and since #78 one function reads them: `status.labels_plan`.

On the host, every app record and every deploy container already has the
0.13 form.

## Changed

- `_read_app` no longer moves `runs` into `image` or `compose_url`.
`Store.open` no longer rewrites records.
- `labels_plan` reads only the 0.13 keys. A deploy container with only
`sha` counts as no plan, so the next check deploys the app once.
- The tests for the 0.12 forms are gone. One test keeps the rule: a
record with no revision or no kind has no plan.
- The changelog says to upgrade a 0.12 host through 0.13.2 first.

## Proof

```
just check
523 passed
```

`uvx vulture app` finds no dead code (only dataclass fields that go out
as JSON and HTTP handler methods). `ruff --select F401,F841,ERA001`
passes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant