starknet_transaction_prover: add CORS and config validation tests#13136
Closed
avi-starkware wants to merge 1 commit intoavi/privacy/error-enum-and-mapping-testsfrom
Closed
starknet_transaction_prover: add CORS and config validation tests#13136avi-starkware wants to merge 1 commit intoavi/privacy/error-enum-and-mapping-testsfrom
avi-starkware wants to merge 1 commit intoavi/privacy/error-enum-and-mapping-testsfrom
Conversation
b047659 to
e9cdab3
Compare
ae8f388 to
cf88612
Compare
This was referenced Mar 10, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 10, 2026
e9cdab3 to
e8b043d
Compare
cf88612 to
1091461
Compare
e8b043d to
fe98fe5
Compare
6235e80 to
6a944e0
Compare
5f41e20 to
b8f14c6
Compare
1eade72 to
662669a
Compare
01f846e to
76aa26a
Compare
783e4ce to
a8827f8
Compare
This was referenced Mar 10, 2026
25f6f3b to
a6246c2
Compare
a8827f8 to
49a3322
Compare
a6246c2 to
c905302
Compare
49a3322 to
f479105
Compare
c905302 to
c3e9ded
Compare
cf86175 to
ce8a83d
Compare
4 tasks
ce8a83d to
8453086
Compare
084d115 to
05724db
Compare
8453086 to
8517456
Compare
3991130 to
347e5ff
Compare
8517456 to
8155738
Compare
347e5ff to
d63c018
Compare
4505c57 to
dbed0f9
Compare
d63c018 to
c4d0f33
Compare
Add 8 CORS tests (layer construction, mode labels, origin normalization edge cases) and 10 config validation tests (missing rpc_url, zero max_concurrent/max_connections, CORS conflicts, config file merging, CLI override precedence). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dbed0f9 to
1b5cafe
Compare
c4d0f33 to
3a65b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Test plan
SEED=0 cargo test -p starknet_transaction_prover -- cors_test— 13 tests passSEED=0 cargo test -p starknet_transaction_prover -- config_test— 33 tests pass (includes pre-existing)🤖 Generated with Claude Code
Note
Low Risk
Test-only changes plus a
#[cfg(test)]module include; no runtime logic changes beyond exercising existing validation paths, so risk is low.Overview
Adds new unit tests for
ServiceConfig::from_argscovering required-field enforcement, numeric argument validation,--no-cors/--cors-allow-originexclusivity, fee validation toggling, and config-file vs CLI precedence.Introduces a dedicated
cors_test.rs(wired via#[cfg(test)]incors.rs) to validate CORS layer construction, mode labeling, and origin normalization edge cases (schemes/host/userinfo/default-port handling).Written by Cursor Bugbot for commit 1b5cafe. This will update automatically on new commits. Configure here.