starknet_committer: create storage tries mode based on wether the storage is async#13360
Closed
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-concurrentlyfrom
Closed
Conversation
5f12deb to
bc2921c
Compare
85bcd2d to
0bec051
Compare
Contributor
Author
0bec051 to
ad3ba6b
Compare
bc2921c to
35887d1
Compare
f4a952c to
d11f258
Compare
a1367a4 to
e350d54
Compare
607ec64 to
9136278
Compare
e350d54 to
7262e62
Compare
9136278 to
062913e
Compare
69f2892 to
288df13
Compare
062913e to
124e06e
Compare
124e06e to
cd1eedb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Moderate risk because it changes core trie-reading control flow and introduces a conditional concurrent path based on
get_async_self(), which could affect performance and correctness under different storage backends.Overview
Storage trie reading now adapts to the storage backend.
create_storage_triesdetects whetherStorage::get_async_self()is available and, if so, builds per-contract storage tries concurrently viaAsyncStorage::gather; otherwise it preserves the existing sequential path.To support this, the forest read path (
read_forestandIndexDb’sForestReaderimpl) broadens storage bounds fromReadOnlyStoragetoStorageand adds stricterSend/'staticlayout bounds needed for concurrent tasks.Written by Cursor Bugbot for commit cd1eedb. This will update automatically on new commits. Configure here.