Skip to content

starknet_committer: create storage tries mode based on wether the storage is async#13360

Closed
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-concurrentlyfrom
nimrod/parallel-reads/based-on-async
Closed

starknet_committer: create storage tries mode based on wether the storage is async#13360
nimrod-starkware wants to merge 1 commit intonimrod/parallel-reads/storage-tries-concurrentlyfrom
nimrod/parallel-reads/based-on-async

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented Mar 19, 2026

Note

Medium Risk
Moderate risk because it changes core trie-reading control flow and introduces a conditional concurrent path based on get_async_self(), which could affect performance and correctness under different storage backends.

Overview
Storage trie reading now adapts to the storage backend. create_storage_tries detects whether Storage::get_async_self() is available and, if so, builds per-contract storage tries concurrently via AsyncStorage::gather; otherwise it preserves the existing sequential path.

To support this, the forest read path (read_forest and IndexDb’s ForestReader impl) broadens storage bounds from ReadOnlyStorage to Storage and adds stricter Send/'static layout bounds needed for concurrent tasks.

Written by Cursor Bugbot for commit cd1eedb. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Mar 19, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review March 19, 2026 13:29
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch from 5f12deb to bc2921c Compare March 19, 2026 14:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch from 85bcd2d to 0bec051 Compare March 19, 2026 14:19
Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented Mar 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch from 0bec051 to ad3ba6b Compare March 22, 2026 06:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch from bc2921c to 35887d1 Compare March 22, 2026 06:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch 2 times, most recently from f4a952c to d11f258 Compare March 25, 2026 11:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch 2 times, most recently from a1367a4 to e350d54 Compare March 25, 2026 11:47
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch 2 times, most recently from 607ec64 to 9136278 Compare March 25, 2026 12:49
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch from e350d54 to 7262e62 Compare March 25, 2026 12:49
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch from 9136278 to 062913e Compare March 25, 2026 13:31
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/storage-tries-concurrently branch 2 times, most recently from 69f2892 to 288df13 Compare March 25, 2026 14:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch from 062913e to 124e06e Compare March 25, 2026 14:24
@nimrod-starkware nimrod-starkware force-pushed the nimrod/parallel-reads/based-on-async branch from 124e06e to cd1eedb Compare March 30, 2026 06:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants