Skip to content

fix(dsh): stop long-thought scroll layout oscillation #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starsstreaming merged 1 commit into from
Oct 6, 2026
Merged

fix(dsh): stop long-thought scroll layout oscillation #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion integrations/deepseek-harness/atmosphere.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ html[data-bc-resolved-tone="light"][data-bc-gallery="true"] body{
--dsw-specific-sidebar-fill:rgba(255,255,255,.36);
}
html[data-bc-gallery="true"] #root{position:relative;z-index:1;background:transparent!important}
html[data-bc-gallery="true"] [class*="_fade"]{display:none!important}
/* Native fade classes belong to scroll content, not decorative overlays.
Hiding them feeds zero geometry back into DSH's ResizeObserver loop (#87). */
html[data-bc-gallery="true"] #beauticode-bg-stage img,
html[data-bc-gallery="true"] #beauticode-bg-stage video{opacity:0!important}
html[data-bc-fish="true"] #root{opacity:0!important;visibility:hidden!important;pointer-events:none!important}
Expand Down
3 changes: 2 additions & 1 deletion integrations/deepseek-harness/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ html[data-bc-bg-blur="true"] #beauticode-bg-stage .beauticode-media-slot video{
}
@media (prefers-reduced-motion:reduce){#beauticode-bg-stage .beauticode-media-slot,#beauticode-bg-stage .beauticode-media-slot img,#beauticode-bg-stage .beauticode-media-slot video{transition:none!important}}
html[data-bc-active="true"] #root{position:relative;z-index:1;background:transparent!important}
html[data-bc-active="true"] [class*="_fade"]{display:none!important}
/* Preserve DSH's native fading scroll bodies; hiding them causes the
ResizeObserver to alternate content between visible and zero height (#87). */
Comment on lines +213 to +214

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve suppression for the conversation-list fade

When an ordinary or gallery background is active, removing this rule also restores DSH's decorative conversation-list bottom fade, which docs/deepseek-harness.md:87 explicitly says is disabled because it renders a dark band over the wallpaper. The repository-wide search finds no replacement suppression, so fixing the reasoning-body oscillation by deleting the broad selector regresses every wallpaper view containing that list; retain a narrower rule targeting the decorative fade while excluding the [data-step-process-body] scroll content.

Useful? React with 👍 / 👎.

html[data-bc-fish="true"] #root{opacity:0!important;visibility:hidden!important;pointer-events:none!important}
`;
document.head.append(style);
Expand Down
20 changes: 20 additions & 0 deletions integrations/deepseek-harness/test/background-rendering.browser.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,26 @@ browserTest("gallery consumes blur and dim preferences in dark and light appeara
assert.equal(reset.overlay, "rgba(255, 255, 255, 0)", "light overlay becomes fully transparent");
});

browserTest("background modes preserve native fading scroll bodies and scroll position (#87)", async (t) => {
const page = await openFixture(t);
for (const mode of ["ordinary", "gallery"]) {
if (mode === "gallery") await openGallery(page);
const frames = await page.evaluate(async () => {
const body = document.querySelector("[data-step-process-body]");
body.scrollTop = 200;
const frames = [];
for (let i = 0; i < 90; i++) {
await new Promise(requestAnimationFrame);
frames.push({ height: body.clientHeight, top: body.scrollTop, mask: getComputedStyle(body).maskImage });
}
return frames;
});
assert.ok(frames.every(frame => frame.height === 400), `${mode}: native content must stay in layout`);
assert.ok(frames.every(frame => frame.top === 200), `${mode}: scrolling must remain stable`);
assert.ok(frames.every(frame => frame.mask.startsWith("linear-gradient")), "retain native fading masks");
}
});

browserTest("closing gallery restores ordinary image and video preference rendering", async (t) => {
const page = await openFixture(t);
await openGallery(page);
Expand Down
1 change: 0 additions & 1 deletion integrations/deepseek-harness/test/plugin.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ test("plugin publishes one ordered browser injection table for Web and Desktop",
/html\[data-bc-resolved-tone="light"\]\[data-bc-dim-user="true"\]\[data-bc-active="true"\] #beauticode-bg-stage::after\{background:rgba\(255,255,255,var\(--bc-dim\)\)!important\}/,
);
assert.match(source, /BeauticodeBackgroundDim/);
assert.match(source, /\[class\*=\"_fade\"\]\{display:none!important\}/);
assert.match(source, /data-bc-resolved-tone/);
assert.match(source, /data-ds-dark-theme/);
assert.doesNotMatch(source, /toggleAttribute\("data-ds-dark-theme"/);
Expand Down
Loading