Load additional certificates specified via SSL_CERT_FILE or SSL_CERT_DIR#33
Closed
sandermvanvliet-stack wants to merge 1 commit into
Closed
Conversation
Author
|
I've just seen #31 which is the better option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our deployment scenario we have to work with a MITM style proxy (zScaler) that re-signs HTTPS traffic. The current implementation appears not to use the system roots which is causing every request to fail.
This PR adds the ability to specify additional CA certificates to be added to the trusted roots used by rustls and reqwest.
Most likely this should instead use rustls-platform-verifier 🤔
I would not suggest to merge this but rather have this as a starter for a better approach.
It has allowed us to progress with our testing by rolling custom builds of the rust parts.