Skip to content

Rename loop property to disableLoop#5

Draft
ibrkhalil wants to merge 2 commits intomainfrom
rename-loop-property-to-disable-loop
Draft

Rename loop property to disableLoop#5
ibrkhalil wants to merge 2 commits intomainfrom
rename-loop-property-to-disable-loop

Conversation

@ibrkhalil
Copy link
Copy Markdown

No description provided.

@ibrkhalil ibrkhalil marked this pull request as draft August 16, 2023 10:16
Comment thread src/index.tsx
type: source.type || '',
},
loop: nativeProps.loop ?? true,
disableLoop: nativeProps.disableLoop ?? true,
Copy link
Copy Markdown

@emmyrlim emmyrlim Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

Suggested change
disableLoop: nativeProps.disableLoop ?? true,
disableLoop: nativeProps.disableLoop ?? false,

in order to keep this consistent with android?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants