-
Notifications
You must be signed in to change notification settings - Fork 90
ci: add Jenkinsfile and config for e2e mobile tests #19163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jenkins BuildsClick to see older builds (74)
|
42e0569 to
220c950
Compare
- wallet locators - app lifecycle management - toast message handling (visibility checks and logging). - saved addresses page
…ertions - Replaced instances of LambdaTest reporting with Cloud reporting - Assertion messages for clarity - Updated test methods for toast handling
162d5a5 to
a21a910
Compare
jakubgs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, but needs some more work. You make a few weird assumptions about availability of env variables.
ci/Jenkinsfile.test-e2e.android
Outdated
| def runId = env.E2E_RUN_ID?.trim() | ||
| def reportsPattern = runId ? "test/e2e_appium/reports/${runId}/**/*.xml" : "test/e2e_appium/reports/**/*.xml" | ||
| junit allowEmptyResults: true, testResults: reportsPattern | ||
| def archivePattern = runId ? "test/e2e_appium/reports/${runId}/**/*" : "test/e2e_appium/reports/**/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this pattern wider than the one above? How are those artifacts useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The junit pattern is for only the final pytest results xml.
The wider pattern captures the reports folder for the run for further analysis when needed, investigating failures etc. It can include screenshots (on fail or when configured), page dumps and logs. It could be possible to use only BrowserStack for this but would have to consider access by wider team if necessary.
0bba4c4 to
0511399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good right now, but I just noticed that you didn't actually run it. We don't yet have a job for this.
So you've been just dry-writing this the whole time? Haha. You will have to ask one of my engineers, for example @markoburcul , to help you set up a job for this. And you're also missing a way to trigger it.
|
Thanks for the feedback @jakubgs Yeah, just based on the other e2e files to start with. I had briefly mentioned to @siddarthkay a while back that this was being worked on but there were dependencies to resolve in the framework itself and the priority has been the recent releases. There's an issue for setting up a job here if that's any help: https://github.com/status-im/infra-ci/issues/222 |
What does the PR do
ci/Jenkinsfile.test-e2e.androidso Jenkins can run Android smoke tests on BrowserStack (in preparation for PR checks and nightly runs)Successfully ran with simulated config locally but still to be tested from Jenkins directly