Skip to content

Conversation

@mmlado
Copy link
Contributor

@mmlado mmlado commented Dec 3, 2025

What does the PR do

The Node Management screen lacked vertical scrollability when the window was resized, causing content to become inaccessible.

This wraps the entire layout in a StatusScrollView to enable scrolling when content exceeds the visible area.

Fixes #12746

Affected areas

Node layout

Architecture compliance

Screencapture of the functionality

fix12746

Impact on end user

Before: If the window was small, the user didn't see all the fields
After: If the window is small, the user can scroll to other fields.

How to test

  1. Select Node Management in the left pane.
  2. Resize the window such that its vertical dimension is low.
  3. Scroll

Risk

Cosmetic changes. Minimal risk.

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Thanks for another quick contribution!

@status-im-auto
Copy link
Member

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 68df39f #1 2025-12-03 18:12:33 ~22 min linux/x86_64-nwaku 📦tgz

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this... I think what should be scrollable is the "Logs" section (or even the inpput field, in case it's multiline), but not the whole view

@mmlado
Copy link
Contributor Author

mmlado commented Dec 4, 2025

Not sure about this... I think what should be scrollable is the "Logs" section (or even the inpput field, in case it's multiline), but not the whole view

The current issue is the bottom content can't be seen. The first two columns are fixed at 300 height, so there is no space left. Would it be better for the mailserver interactions and logs fields to resize based on the window size?

@caybro
Copy link
Member

caybro commented Dec 4, 2025

Not sure about this... I think what should be scrollable is the "Logs" section (or even the inpput field, in case it's multiline), but not the whole view

The current issue is the bottom content can't be seen. The first two columns are fixed at 300 height, so there is no space left. Would it be better for the mailserver interactions and logs fields to resize based on the window size?

Yes, definitely (it can be a ratio, like 1/3); nothing should be hardcoded like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node Management window is not vertically scrollable

4 participants