Fix byte encoding#4
Open
viniciuslrangel wants to merge 1 commit intostefanuros:masterfrom
viniciuslrangel:patch-1
Open
Fix byte encoding#4viniciuslrangel wants to merge 1 commit intostefanuros:masterfrom viniciuslrangel:patch-1
viniciuslrangel wants to merge 1 commit intostefanuros:masterfrom
viniciuslrangel:patch-1
Conversation
- Using utf8 chars with more than 1 bytes adds a wrong offset to the loop (accessing the wrong index from val) - Chars that starts with a zero (like 0x0A), `toRadixString(16)` gives a string with length == 1 resulting in a index out of range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toRadixString(16)gives a string with length == 1 resulting in a index out of range