chore: update implementation checklist with lessons learned - #2081
Merged
Conversation
Lessons-learned sync for the v2.15.0 release (/release step 6). Adds the seven recurring review patterns present in product-owner, ux-designer and product-architect memory that the checklist did not already cover. - Frontend/Shared Components: a component in components/ is not automatically shareable -- it keeps its origin feature's i18n namespace and testids (#2060, PR #2063). - Frontend/React Hooks: an epoch guard protects the returned value, never the side effects the injected callback performs on the way there. - Backend/API Conventions: an env var must land in all four documentation sites, and a stated variable count is a second drift surface. - Testing: every assertion must be able to fail; DataTable mounts desktop and mobile DOM simultaneously so un-overridden testids exist twice; a docs-only PR's green gates prove nothing because no CI job builds the docs site. - New section, Acceptance Criteria & Specs: an AC whose premise contradicts the code is a defect in the acceptance record, and premises go stale at pickup rather than at filing. The diff is purely additive. Prettier is deliberately NOT run on this file: it is not CI-gated for .claude/**, and the committed file uses *emphasis* where prettier would rewrite to _emphasis_, so formatting it would produce nine lines of unrelated drift. The added lines follow the file's existing style. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.15.0-beta.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lessons-learned sync for the v2.15.0 release (
/releasestep 6). Adds the seven recurring review patterns found inproduct-owner,ux-designer, andproduct-architectmemory that the checklist did not already cover.components/is not automatically shareable — one born inside a feature keeps that feature's i18n namespace anddata-testidstrings (#2060, PR #2063)DataTablemounts desktop + mobile DOM simultaneously, so un-overridden testids exist twice (#2046, PR #2068; sweep deferred to #2069)Candidates were checked against existing entries and rejected where already covered — e.g. focus-loss on self-disabling controls (covered by Focus management) and the ungated Prettier fact (already mandated by CLAUDE.md's Local Validation Policy).
Note on formatting
The diff is purely additive (15 insertions, 0 deletions). Prettier is deliberately not run on this file: it is not CI-gated for
.claude/**, and the committed file uses*emphasis*where Prettier would rewrite to_emphasis_— formatting it would produce nine lines of unrelated drift across untouched entries. The added lines follow the file's existing style.🤖 Generated with Claude Code