Migrate operations/ files to TS [5/6]#912
Merged
quietbits merged 8 commits intotypescript-migrationfrom Mar 6, 2026
Merged
Conversation
10 tasks
|
Size Change: -1.66 kB (-0.05%) Total Size: 3.59 MB
|
There was a problem hiding this comment.
Pull request overview
Migrates several operations/ modules from JS to TS and centralizes option typings for improved type-safety during operation construction.
Changes:
- Added new operation option interfaces to
src/operations/types.ts. - Converted multiple operations to TypeScript/ESM-style imports and typed
OperationAttributes. - Replaced/remove legacy JS operation implementations with TS equivalents.
Reviewed changes
Copilot reviewed 9 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/operations/types.ts | Adds typed option interfaces used by the migrated operations. |
| src/operations/revoke_sponsorship.ts | Converts revoke-sponsorship operation builders to TS and shared option types. |
| src/operations/path_payment_strict_send.ts | New TS implementation of pathPaymentStrictSend. |
| src/operations/path_payment_strict_send.js | Removes legacy JS implementation after TS migration. |
| src/operations/create_claimable_balance.ts | Converts create-claimable-balance builder to TS and typed attributes. |
| src/operations/clawback_claimable_balance.ts | New TS implementation of clawbackClaimableBalance. |
| src/operations/clawback_claimable_balance.js | Removes legacy JS implementation after TS migration. |
| src/operations/claim_claimable_balance.ts | New TS implementation of claimClaimableBalance + validator. |
| src/operations/claim_claimable_balance.js | Removes legacy JS implementation after TS migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Ryang-21
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests will be added in a separate PR (#896).