Qualify getLedgers history by provider retention#73
Open
kaankacar wants to merge 1 commit into
Open
Conversation
The skill promised Infinite Scroll back to genesis unconditionally.
Reality, reproduced live against the public testnet RPC while writing
this: getHealth reports oldestLedger/ledgerRetentionWindow, and
getLedgers with startLedger=2 fails with -32600 ('must be between the
oldest ledger ... for this rpc instance'). Deep history is a property
of the provider's data-lake integration, not of the method.
All four references now say so, and the historical-data example
checks getHealth().oldestLedger before paging back.
Closes #52.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52.
Applies the report, re-verified live while writing the fix:
getHealthon the public testnet RPC returnedoldestLedger: 3590554,latestLedger: 3711513,ledgerRetentionWindow: 120960, andgetLedgerswithstartLedger: 2failed with JSON-RPC-32600— the error text itself says "must be between the oldest ledger ... for this rpc instance", which is the whole point: deep history is a property of the provider's data-lake integration, not of the method.All four "back to genesis" references are qualified (RPC limitations bullet, the historical-data code comment, the Historical Data Access intro, and the Data Lake section), and per the issue's recommendation the code example now checks
getHealth().oldestLedgerbefore paging back.