SPIKE: Protocol 28 (CAP-0085) - #207
Merged
Merged
Conversation
* Bump core to v27.1.0 for CI. * !fixup Bump a stray v27 image
Pin go-stellar-sdk to the unmerged fork branch carrying the regenerated XDR for CAP-0085 (new ContractExecutable external-ref variant + SCV_EXECUTABLE_TAG SCVal arm). Cross-links go-stellar-sdk#5965. - go.mod: replace github.com/stellar/go-stellar-sdk => github.com/sisuresh/go - CHANGELOG: note Protocol 28 (CAP-0085) ingestion support; MaxSupportedProtocolVersion already 28 - go.yml: add -timeout 25m to unit-test run for CI stability
Adds the create_and_invoke_external_ref_contract LedgerCloseMeta capture (9de1ea718b77ffa2.xdr) produced by stellar-core's CAP-85 host tests (stellar-core#5358) so TestCoreLCMIngestion exercises horizon's ingestion of the new ContractExecutable external-ref variant and SCV_EXECUTABLE_TAG SCVal arm. Verified the fixture decodes with the regenerated go-stellar-sdk XDR (go-stellar-sdk#5965). index.json updated with the matching descriptor.
Contributor
Author
|
Added the CAP-0085 |
Empty commit to force a fresh CI run. Previous run 29947538259 failed on flaky 'Transaction Submission Timeout' panics in TestContractTransferBetweenAccounts and TestTrustlineRevocationEvents, with fail-fast cancelling the remaining integration legs. No source changes.
go-stellar-sdk#5965 (Protocol 28 / CAP-0085 XDR regen) merged to protocol-next as 82df7643786e0f8e4f82f4d36e522af8c45bf101. Drop the sisuresh/go fork replace and pin the merged commit (v0.6.1-0.20260722220414-82df7643786e). No more fork ref, so the earlier GOPRIVATE/sumdb workaround is no longer needed.
sisuresh
marked this pull request as ready for review
July 23, 2026 00:45
Drop the -timeout 25m added on the SPIKE branch; restore the base 'go test -race -cover ./...'. The bump was an unjustified carry-over — the unit test job runs well under Go's 10m default, so the extra ceiling bought nothing and was out-of-scope churn on a workflow file.
urvisavla
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XDR regen consumed from go-stellar-sdk stellar/go-stellar-sdk#5965 (pinned via a
replacedirective ingo.modto thesisuresh/gofork branch).Supersedes closed #205; cross-links stellar-xdr#308.
What this does
go-stellar-sdkto the unmerged fork branch carrying the regenerated XDR for CAP-0085 (newContractExecutableexternal-reference variant +SCV_EXECUTABLE_TAGSCValarm). No bespoke contractevents handling: CAP-0085 does not change SAC events; only theexecutable_updatesystem event'sContractExecutablerepresentation, handled purely by the regenerated go-sdk XDR.MaxSupportedProtocolVersionis already 28 onprotocol-next— not touched..github/workflows/go.yml: add-timeout 25mto the unit-test run for CI stability.Still a SPIKE
Because it pins the unmerged go-sdk branch. Flip the
go.modreplaceback to a version pin once go-stellar-sdk#5965 merges.