Protocol 28 (CAP-0085) - #891
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…w-list go-stellar-sdk#5965 (Protocol 28 / CAP-0085) merged to protocol-next as 82df7643786e0f8e4f82f4d36e522af8c45bf101. Drop the sisuresh/go fork replace, pin the merged commit (v0.6.1-0.20260722220414-82df7643786e), and remove the paired .golangci.yml gomoddirectives replace-allow-list (now-empty stanza deleted). Rust preflight pins (merged rs-soroban-env / rs-stellar-xdr) unchanged.
The merged CAP-0085 rs-soroban-env commit (88cadc3) advanced its baseline:
the default (non-next) build now declares protocol 28, while 'next' declares
protocol 29. The preflight dispatches by exact protocol number
(proto == curr::PROTOCOL), so with 'next' enabled curr::PROTOCOL was 29 and
ledgers at protocol 28 were rejected ('unsupported protocol version: 28',
TestGetPreflight/protocol_28). Drop the 'next' feature so curr::PROTOCOL == 28.
CAP-0085 XDR types are unaffected — the host pins stellar-xdr with
cap_0085_executable_ref in its own workspace, independent of 'next'.
Verified locally: make build-libs + go test ./.../preflight TestGetPreflight* pass.
sisuresh
marked this pull request as ready for review
July 23, 2026 16:49
sisuresh
marked this pull request as draft
July 23, 2026 16:57
sisuresh
marked this pull request as ready for review
July 23, 2026 16:58
…host
The P28 integration leg was failing with ScecExceededLimit ('operation
instructions exceeds amount specified') because the previous core image
(27.0.1-3367.3589a696b) predated rs-soroban-env#1702's cost-model update, so
apply-time metering diverged from the preflight's simulation. Repin to
27.1.1-3444.0e3d3d955.jammy-vnext: a vnext build of stellar-core master that
includes CAP-85 core support (stellar-core#5358) and whose src/rust/soroban/p28
submodule is 88cadc32 — the exact rs-soroban-env commit soroban-env-host-curr
pins. Host commit now matches on both sides, so the cost models agree.
Docker manifest + jammy~vnext deb both verified present in the registry/apt pool.
sisuresh
marked this pull request as draft
July 23, 2026 22:26
sisuresh
marked this pull request as ready for review
July 24, 2026 16:22
urvisavla
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust preflight pinned to MERGED rs-soroban-env
88cadc320cd2030bae2110036b361ff474776db1(stellar/rs-soroban-env#1703) + rs-stellar-xdra90de0c0d6eba8be668e9074cfb7b285ac0ecd34(stellar/rs-stellar-xdr#556 — the exact rev the host pins, so cargo unifies the preflight's stellar-xdr with the host's into one package). The stellar-xdr feature set addscap_0085_executable_reffor the newContractExecutablevariant.soroban-env-host-currdeliberately does not enable thenextfeature: at the merged CAP-0085 commit rs-soroban-env's baseline has advanced so the default (non-next) build already declares protocol 28, whilenextnow declares protocol 29. The preflight dispatches by exact protocol number, so enablingnextwould make it reject ledgers at protocol 28.Go side pins the MERGED go-stellar-sdk commit
82df7643786e0f8e4f82f4d36e522af8c45bf101(stellar/go-stellar-sdk#5965) directly ingo.mod— noreplacedirective, and the earlier.golangci.ymlgomoddirectives.replace-allow-listexception has been removed.Supersedes closed #853. Cross-links: stellar/stellar-xdr#308, stellar/go-stellar-sdk#5965.
All upstream pins are now merged. This remains a draft because (a) the Rust dependencies are pinned by git rev rather than published crates.io releases, and (b) per this run's mandate every PR in the stack stays a draft pending human review.