fix(orm): preserve Scanner in Query.Clone() - #724
Merged
stephenafamo merged 2 commits intoJul 7, 2026
Conversation
Query.Clone() only cloned the embedded ExecQuery and dropped the Scanner, so All/One/Cursor/Each on a cloned query panicked with a nil pointer dereference. Copy the Scanner in Clone() and add a regression test mirroring TestModQueryWithPreservesScanner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orm.Query.Clone()only clones the embeddedExecQueryand never copiesScanner,so any cloned query has a nil scanner and
All/One/Cursor/Eachpanic:Fix
Copy the
ScannerinClone()(one line), and add a regression test(
TestQueryClonePreservesScanner) mirroring the existingTestModQueryWithPreservesScanner. The test fails onmainand passes with the fix.Noticed while working on #715: with the mapper flowing through
q.Scanner,a clone silently dropping it is easier to hit than before.