Skip to content

fix bug with addAttributeToSelect - can cause MySQL Error #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magefast wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix bug with addAttributeToSelect - can cause MySQL Error #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2668dac
fix bug with addAttributeToSelect - can cause MySQL Error: Too many t…
magefast Apr 22, 2023
004e1d4
Merge pull request #1 from magefast/Critical-bug-with-addAttributeToS…
magefast Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 3 additions & 33 deletions Model/Resolver/Products/DataProvider/Product/CollectionProcessor/SFXAttributesProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,19 @@

use Magento\Catalog\Model\ResourceModel\Product\Collection;
use Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Product\CollectionProcessorInterface;
use Magento\Eav\Api\Data\AttributeInterface;
use Magento\Framework\Api\SearchCriteriaBuilder;
use Magento\Framework\Api\SearchCriteriaInterface;
use Magento\GraphQl\Model\Query\ContextInterface;
use Magento\Eav\Api\AttributeRepositoryInterface;
use Magento\Framework\Api\FilterBuilder;
use Magento\Catalog\Api\Data\ProductAttributeInterface;
use StorefrontX\ProductAttributesGraphQl\Model\IgnoredFields;

class SFXAttributesProcessor implements CollectionProcessorInterface
{
private IgnoredFields $ignoredFields;
private AttributeRepositoryInterface $attributeRepository;
private SearchCriteriaBuilder $searchCriteriaBuilder;
private FilterBuilder $filterBuilder;

public const SFX_ATTR_KEY = 'sfx_attributes';

public function __construct(
AttributeRepositoryInterface $attributeRepository,
SearchCriteriaBuilder $searchCriteriaBuilder,
FilterBuilder $filterBuilder,
IgnoredFields $ignoredFields
) {
$this->attributeRepository = $attributeRepository;
$this->searchCriteriaBuilder = $searchCriteriaBuilder;
$this->filterBuilder = $filterBuilder;
$this->ignoredFields = $ignoredFields;
}

Expand All @@ -53,28 +39,12 @@ public function process(
): Collection {

if (in_array(self::SFX_ATTR_KEY, $attributeNames)) {
$attributes = $this->getAttributes();
foreach ($attributes as $attribute) {
if (!in_array($attribute->getAttributeCode(), $this->ignoredFields->getIgnoredFields())) {
$collection->addAttributeToSelect($attribute->getAttributeCode(), true);
}
$ignoredFields = $this->ignoredFields->getIgnoredFields();
foreach ($ignoredFields as $field) {
$collection->removeAttributeToSelect($field);
}
}

return $collection;
}

/**
* @return AttributeInterface[]
*/
private function getAttributes(): array
{
$attributes = $this->attributeRepository->getList(
ProductAttributeInterface::ENTITY_TYPE_CODE,
$this->searchCriteriaBuilder
->addFilter('is_visible_on_front', 1)
->create()
);
return $attributes->getItems();
}
}