Fixed all includes according to coding style - #1039
Draft
volkm wants to merge 4 commits into
Draft
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
It introduces new CI enforcement and applies a very large mechanical include sweep that warrants a final human verification pass (especially for build/config edge cases).
Pull request overview
Adds automated style enforcement to Storm by introducing a dedicated style-check script + CI workflow, and applies a broad include-order cleanup across the C++ codebase so the new checks can be enabled without mass violations.
Changes:
- Added
resources/scripts/check_style.py(include-order / pragma-once / raw-throw checks) plus.check-style-ignoreexceptions list. - Added a GitHub Actions workflow to run formatting and selected style checks on pushes/PRs.
- Performed a repository-wide include cleanup (own-header first, then
<...>, then"storm/..."), plus a small adapter include consolidation for CUDD.
File summaries
| File | Description |
|---|---|
| resources/scripts/check_style.py | Implements the style checks that will be enforced in CI. |
| .github/workflows/style-check.yml | Runs clang-format and the new style checker in CI. |
| .check-style-ignore | Defines per-check exceptions to keep the style checks practical. |
| src/storm/adapters/cudd.h | Wraps optional CUDD C++ interface include behind STORM_HAVE_CUDD. |
| src/storm/storage/dd/cudd/utility.h | Switches to the new CUDD adapter header include. |
| .clang-tidy | Enables an additional clang-tidy performance check. |
| src/** (many .cpp/.h) | Mechanical include-order normalization to satisfy the new style rules. |
Review details
- Files reviewed: 300/1082 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
volkm
added
the
delay merge
volkm
marked this pull request as draft
September 7, 2026 14:47
volkm
changed the title
volkm
force-pushed
the
header-includes
branch
from
September 7, 2026 15:59
241a910 to
a7e2add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1038 and #1044
Fix all includes such that they adhere to the coding style now. This could afterwards be put it into
git-blame-ignore-revs.Notable insights from the includes:
Formula.cpp,JaniConversionOptions.cpp,SubEnvironment.cppadapter/sylvan.cppandstring.cppneed to include their headers with absolute path because they already exist in the systemExplicitQuantitativeCheckResult.cpprequired a fixed include order in the past, but it seems to work now.