#118 action plan should include multiple files#119
Open
n3o2k7i8ch5 wants to merge 30 commits into
Open
Conversation
…ould-include-multiple-files # Conflicts: # libs/core/deep_next/core/steps/action_plan/action_plan.py # libs/core/deep_next/core/steps/gather_project_knowledge/project_description/generate_project_description.py # libs/core/deep_next/core/steps/implement/develop_patch.py
…ould-include-multiple-files # Conflicts: # libs/common/deep_next/common/llm.py # libs/core/deep_next/core/steps/action_plan/action_plan.py # libs/core/deep_next/core/steps/action_plan/srf/file_selection/graph.py # libs/core/deep_next/core/steps/gather_project_knowledge/project_description/generate_project_description.py
…ould-include-multiple-files # Conflicts: # libs/core/deep_next/core/steps/action_plan/srf/file_selection/utils.py
…ould-include-multiple-files # Conflicts: # libs/core/deep_next/core/graph.py # libs/core/deep_next/core/steps/action_plan/action_plan.py # libs/core/deep_next/core/steps/implement/apply_patch/apply_patch.py # llm-config.yaml
n3o2k7i8ch5
commented
Jun 6, 2025
n3o2k7i8ch5
commented
Jun 6, 2025
n3o2k7i8ch5
commented
Jun 6, 2025
n3o2k7i8ch5
commented
Jun 6, 2025
n3o2k7i8ch5
commented
Jun 6, 2025
n3o2k7i8ch5
commented
Jun 6, 2025
n3o2k7i8ch5
commented
Jun 6, 2025
stxpatryk
reviewed
Jun 10, 2025
Comment on lines
+251
to
+254
| seed (int | None): Optional seed for reproducibility. If provided, it will be | ||
| added to the base seed from the config (as long as the config seed is not | ||
| None. If the config seed is not provided, this value will be used as seed | ||
| itself). |
Contributor
There was a problem hiding this comment.
way too complicated. I'd stick with config based seed and if config seed is something like -1 then we do random. All retry mechanism might just implement +1 mechanism to the config seed. What do you think?
| issue_comments=issue_comments, | ||
| ) | ||
|
|
||
| def steps_to_str(self, steps: list[Step]): |
| related_code_context = "\n".join( | ||
| [f"File: {file_path}\n{read_txt(file_path)}" for file_path in related_files] | ||
| [ | ||
| f"File: {path}\n{read_txt_or_none(path) or '<Failed to read file>'}" |
Contributor
There was a problem hiding this comment.
that might be an issue with files. From my perspective silent exception is a big problem. What do You think of making it regular loop and do the error handling here? read_txt_or_none is created in core.io only for this one usage, isn't that unnecessary?
Contributor
Author
There was a problem hiding this comment.
No problem, but what would you like to do with an FileNotFound exception in the loop? Raise a warning, or something else?
Contributor
Author
There was a problem hiding this comment.
Log warning if byte object or if file not found
|
|
||
| for step in action_plan.ordered_steps: | ||
| for target_file in step.target_files: | ||
| abs_path = root_path / target_file |
Contributor
There was a problem hiding this comment.
why not to keep try_to_resolve_path?
| FileCodeContext( | ||
| path=relevant_file.path, | ||
| code_snippet=read_txt(relevant_file.path), | ||
| code_snippet=read_txt(state.root_path / relevant_file.path), |
Contributor
There was a problem hiding this comment.
that is also a good candidate for try_to_resolve_path
stxpatryk
suggested changes
Jun 12, 2025
Comment on lines
+338
to
+339
| if (seed := config.seed) is None: | ||
| seed += seed_increment |
Contributor
There was a problem hiding this comment.
I guess it will fail None += seed_increment, shouldn't be not None?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118