Skip to content

Remove published-url input from call-release-pr workflow - #142

Merged
ybiquitous merged 2 commits into
mainfrom
release-pr-packages
Oct 26, 2026
Merged

ybiquitous merged 2 commits into
mainfrom
release-pr-packages

Conversation

@ybiquitous

Copy link
Copy Markdown
Member

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

Generate the release PR body from package.json files changed since the base commit.
List each package in a table with its compare and published URLs.
This covers not only npm packages, but also VS Code extensions (indeed, vscode-stylelint).

This change also helps standardize release PR workflows across the organization.
Ref: https://github.com/stylelint/vscode-stylelint/blob/5265ccc77a6ce1f4b9729e1d1434a9c590155040/.github/workflows/release-pr.yml

Generate the release PR body from `package.json` files changed since the base commit.
List each package in a table with its compare and published URLs.
This covers not only npm packages, but also VS Code extensions (indeed, `vscode-stylelint`).

This change also helps standardize release PR workflows across the organization.
Ref: https://github.com/stylelint/vscode-stylelint/blob/5265ccc77a6ce1f4b9729e1d1434a9c590155040/.github/workflows/release-pr.yml
@ybiquitous
ybiquitous requested a review from a team as a code owner October 26, 2026 07:54

@jeddy3 jeddy3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice standardisation.

LGTM, thank you.

Include private packages in the release PR body with an `N/A` published URL instead of skipping them.

Use a scoped tag only when it exists, so a scoped root package still uses the version tag.
@ybiquitous ybiquitous mentioned this pull request Oct 26, 2026
4 tasks
@ybiquitous

Copy link
Copy Markdown
Member Author

Much appreciated the quick review! Testing was successful; see PR #143.

@ybiquitous

Copy link
Copy Markdown
Member Author

Also tested this in the vscode-stylelint repo. Looks good. 👍🏼

@ybiquitous
ybiquitous merged commit e3baba6 into main Oct 26, 2026
18 checks passed
@ybiquitous
ybiquitous deleted the release-pr-packages branch October 26, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants