This repository was archived by the owner on Sep 21, 2024. It is now read-only.
chore: async compat to tokio utils - #725
Merged
Merged
Conversation
…3 has issues with wasm32
jsantell
force-pushed
the
async-compat-to-tokio-utils
branch
from
November 15, 2023 18:54
7d0faa3 to
2da9bdc
Compare
Contributor
Test flake analysis
Flake summary for
|
jsantell
marked this pull request as ready for review
November 21, 2023 21:35
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues with async-compat@0.2.3 in wasm32, and this lets us continue using tokio-family crates.
Dependent on upstream subtext subconsciousnetwork/subtext#59 landing
Fixes potentially multiple subtext instances (workspace consolidation)