Skip to content
This repository was archived by the owner on Sep 21, 2024. It is now read-only.

chore: async compat to tokio utils - #725

Merged
cdata merged 4 commits into
mainfrom
async-compat-to-tokio-utils
Jan 16, 2024
Merged

chore: async compat to tokio utils#725
cdata merged 4 commits into
mainfrom
async-compat-to-tokio-utils

Conversation

@jsantell

Copy link
Copy Markdown
Contributor

Issues with async-compat@0.2.3 in wasm32, and this lets us continue using tokio-family crates.

Dependent on upstream subtext subconsciousnetwork/subtext#59 landing

Fixes potentially multiple subtext instances (workspace consolidation)

@jsantell jsantell changed the title Async compat to tokio utils chore: async compat to tokio utils Nov 15, 2023
@jsantell
jsantell force-pushed the async-compat-to-tokio-utils branch from 7d0faa3 to 2da9bdc Compare November 15, 2023 18:54
@jsantell
jsantell requested a review from cdata November 15, 2023 19:14
@github-actions

github-actions Bot commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Test flake analysis

status platform features toolchain
🟢 ubuntu-latest test-kubo,headers stable
🟡 windows-latest test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers nightly
🟢 macos-13 test-kubo,headers,rocksdb stable
🟡 macos-13 test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable

Flake summary for windows-latest, test-kubo,headers, stable

     Summary [ 225.777s] 175 tests run: 175 passed (1 flaky), 1 skipped
   FLAKY 2/5 [  33.708s] noosphere::distributed_stress latency::clients_can_sync_when_there_is_a_lot_of_content

Flake summary for macos-13, test-kubo,headers, stable

     Summary [  57.353s] 176 tests run: 176 passed (3 flaky), 1 skipped
   FLAKY 2/5 [   1.805s] noosphere-ns dht::node::test::test_dhtnode_bootstrap
   FLAKY 2/5 [   2.153s] noosphere::distributed_basic all_of_client_history_is_made_manifest_on_the_gateway_after_sync
   FLAKY 2/5 [  15.774s] noosphere::distributed_stress multiplayer::orb_can_render_peers_in_the_sphere_address_book

@jsantell
jsantell marked this pull request as ready for review November 21, 2023 21:35
@cdata
cdata merged commit 5f67c26 into main Jan 16, 2024
@cdata
cdata deleted the async-compat-to-tokio-utils branch January 16, 2024 21:24
@cdata

cdata commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants