feat(isthmus): add struct-based user-defined type literal support #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbellick
force-pushed
the
benbellick/udt-struct-literal-support
branch
from
dfc898c to
569b512
Compare
Adds test coverage for struct-encoded UDT literals that contain list and map typed fields to ensure proper roundtrip conversion.
benbellick
commented
Jan 16, 2026
|
|
||
| private InnerType(boolean nullable, String name) { | ||
| computeDigest(); | ||
| this.nullable = nullable; |
Member
Author
There was a problem hiding this comment.
Was this a bug before? I thought that computeDigest() had to be the last thing called.
Member
Author
|
I'll be honest and say that I used a lot of agentic coding to figure this one out due to my lack of familiarity with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #612