♿️(frontend) use heading element for pinned documents section title#2380
♿️(frontend) use heading element for pinned documents section title#2380Ovgodd wants to merge 1 commit into
Conversation
1b19ff3 to
0e81926
Compare
0e81926 to
1667528
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR changes LeftPanelFavorites to render the pinned documents container as a section and the title as a semantic h2 (removing the prior aria-labelledby and title id). It also adds a changelog entry documenting the accessibility update. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: -1 B (0%) Total Size: 4.33 MB 📦 View Changed
|
Replace <span> with <h2> so the section appears in the heading for SR.
1667528 to
74609b4
Compare
Purpose
Replace the
<span>section title with an<h2>for the "Pinned documents" section in the left panel (LeftPanelFavorites).Proposal
<h2>viaText as="h2"aria-labelledbyandid="pinned-docs-title"from the<section>$margin="0") to preserve the existing visual appearance