Skip to content

♿️(frontend) use heading element for pinned documents section title#2380

Open
Ovgodd wants to merge 1 commit into
mainfrom
fix/a11y-2349-pinned-doc-title-semantic
Open

♿️(frontend) use heading element for pinned documents section title#2380
Ovgodd wants to merge 1 commit into
mainfrom
fix/a11y-2349-pinned-doc-title-semantic

Conversation

@Ovgodd
Copy link
Copy Markdown
Collaborator

@Ovgodd Ovgodd commented Jun 2, 2026

Purpose

Replace the <span> section title with an <h2> for the "Pinned documents" section in the left panel (LeftPanelFavorites).

Proposal

  • Render "Pinned documents" as <h2> via Text as="h2"
  • Remove aria-labelledby and id="pinned-docs-title" from the <section>
  • Reset heading margin ($margin="0") to preserve the existing visual appearance

@Ovgodd Ovgodd requested a review from AntoLC June 2, 2026 15:00
@Ovgodd Ovgodd self-assigned this Jun 2, 2026
@Ovgodd Ovgodd added bug Something isn't working accessibility labels Jun 2, 2026
@Ovgodd Ovgodd added the triage label Jun 2, 2026
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 1b19ff3 to 0e81926 Compare June 2, 2026 15:01
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Jun 2, 2026
@Ovgodd Ovgodd linked an issue Jun 2, 2026 that may be closed by this pull request
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 0e81926 to 1667528 Compare June 2, 2026 15:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3766a0f8-ec08-4ee0-a1fc-67acf7f82f57

📥 Commits

Reviewing files that changed from the base of the PR and between 1667528 and 74609b4.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsx

Walkthrough

This PR changes LeftPanelFavorites to render the pinned documents container as a section and the title as a semantic h2 (removing the prior aria-labelledby and title id). It also adds a changelog entry documenting the accessibility update.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • AntoLC
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: converting the pinned documents section title to a semantic heading element (h2) for accessibility improvements.
Description check ✅ Passed The description is directly related to the changeset, outlining the purpose of replacing a span with an h2 and the specific implementation details that match the code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/a11y-2349-pinned-doc-title-semantic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Size Change: -1 B (0%)

Total Size: 4.33 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/ae9dfd58/_buildManifest.js 672 B +672 B (new file) 🆕
apps/impress/out/_next/static/feb3ebe1/_buildManifest.js 0 B -673 B (removed) 🏆

compressed-size-action

Replace <span> with <h2> so the section appears in the heading for SR.
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 1667528 to 74609b4 Compare June 3, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility bug Something isn't working triage

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

"Pinned Documents" section: section title without heading semantics

1 participant