Fix/a11y share modal sr focus announcements#214
Open
Ovgodd wants to merge 3 commits into
Open
Conversation
Improve SR feedback and keyboard continuity after invite/role actions.
Make role/remove actions explicit for screen readers across member rows.
Prevent icon glyph names from being announced as meaningful content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve ShareModal accessibility for screen readers and keyboard users:
What stays on shared primitives: menu popup semantics and dialog/menu announcement noise are still partly driven by UI kit / Cunningham components. Related work is tracked in ui-kit PR #210 and Cunningham PR #390.
Three commits on purpose (flow + labels, then icon noise cleanup).
Proposal
aria-labels on role, remove-user, and show-more controls (members vs invitations).h3) for SR heading navigation.search,add,close,arrow_*,link) witharia-hidden="true".role="menu"+ trigger ARIA instead of dialog popup semantics).