Skip to content

Fix/a11y share modal sr focus announcements#214

Open
Ovgodd wants to merge 3 commits into
mainfrom
fix/a11y-share-modal-sr-focus-announcements
Open

Fix/a11y share modal sr focus announcements#214
Ovgodd wants to merge 3 commits into
mainfrom
fix/a11y-share-modal-sr-focus-announcements

Conversation

@Ovgodd

@Ovgodd Ovgodd commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Improve ShareModal accessibility for screen readers and keyboard users:

  • reduce noisy announcements from decorative UI
  • add clear, contextual labels on action controls
  • keep focus predictable after invite/member actions
  • announce add/remove/role-change feedback even when focus stays on the same control

What stays on shared primitives: menu popup semantics and dialog/menu announcement noise are still partly driven by UI kit / Cunningham components. Related work is tracked in ui-kit PR #210 and Cunningham PR #390.

Three commits on purpose (flow + labels, then icon noise cleanup).

Proposal

  • Add contextual aria-labels on role, remove-user, and show-more controls (members vs invitations).
  • Return focus to the search input after adding or removing a pending invited user.
  • Add a polite live region for add/remove user and role-change confirmations.
  • Use a short clear-then-set delay so confirmations are still announced when dropdown close noise happens.
  • Expose ShareModal section titles as headings (h3) for SR heading navigation.
  • Hide decorative Material Icons (search, add, close, arrow_*, link) with aria-hidden="true".
  • Verify role/remove/show-more labels, invite focus flow, live confirmations, icon noise cleanup, and heading navigation.
  • Document remaining dropdown-close SR dump after role/reach selection as out of scope for ShareModal; expected to improve with ui-kit PR #210 (role="menu" + trigger ARIA instead of dialog popup semantics).

Ovgodd added 3 commits May 5, 2026 10:44
Improve SR feedback and keyboard continuity after invite/role actions.
Make role/remove actions explicit for screen readers across member rows.
Prevent icon glyph names from being announced as meaningful content.
@Ovgodd Ovgodd self-assigned this May 5, 2026
@Ovgodd Ovgodd marked this pull request as draft May 5, 2026 08:54
@Ovgodd Ovgodd requested a review from PanchoutNathan May 5, 2026 09:02
@Ovgodd Ovgodd added the Accessibility Accessibility Update label May 5, 2026
@Ovgodd Ovgodd marked this pull request as ready for review May 5, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Accessibility Update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant