♿️(menu) add opensInNewWindow for external link aria-label#246
Open
Ovgodd wants to merge 2 commits into
Open
Conversation
Add opensInNewWindow to MenuItemAction; append i18n suffix to aria-label only
Add OpensInNewWindow Storybook story to verify external link aria-label suffix
b5d1ce1 to
da1fe3f
Compare
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve dropdown and context menu accessibility for screen readers when items open external links
When a menu item opens a link in a new page or tab, screen readers must announce it:
labelas the only visible text for menu itemsaria-labelsuffix for supported UI Kit localesProposal
Dom example :
Usage (Docs)