fix(auth): suppress getsession warning when getuser is called first #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when getuser() returns a valid user, suppress the insecure user warning for subsequent getsession() calls since the developer is already following best practices by verifying the user with the auth server. closes supabase#1895
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
reset suppressgetsessionwarning to false in _removesession() to ensure the security warning is re-enabled after sign-out or session changes, preventing stale suppression across different user sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
when getuser() returns a valid user, suppress the insecure user warning for subsequent getsession() calls since the developer is already following best practices by verifying the user with the supabase auth server.
problem
the warning using the user object as returned from supabase.auth.getsession()... fires every time getsession() is called, even when the developer also calls getuser() to verify the user. this creates noisy, misleading logs.
solution
set suppressgetsessionwarning = true when getuser() successfully returns a user, preventing the warning from firing on subsequent getsession() calls.
changes
closes #1895