Fix terminal Control input on non-Latin keyboard layouts#613
Open
ERuban wants to merge 1 commit into
Open
Conversation
Collaborator
|
Adding it here too since it went unnoticed in the issue. Is this reproducible in Ghostty, by any chance? @ERuban |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #612
Summary
Fix layout-dependent terminal Control-key input in Supacode tabs.
When a non-Latin macOS input source is active, interactive terminal programs such as Claude or Codex may not receive plain terminal Control chords consistently. For example, pressing the physical
⌃Ckeys with a Russian layout selected may not cancel/exit the program, while the same physical shortcut works after switching back to an English layout.This change resolves plain terminal Control chords from the physical keyCode using the US-QWERTY key position before passing input to Ghostty. Regular text input remains layout-aware, and app/menu shortcuts are not affected.
Type of change
ready)How was this tested?
make checkpasses (format + lint)make testpassesmake testandmake build-appcould not run locally because my machine has Xcode 27, and the project preflight requires a Zig-linkable Xcode/macOS SDK combination.I'd appreciate it if someone could test it.
AI tool disclosure (optional)
Checklist
Closes #above.ready.