Skip to content

Fix OMP presence after subagent shutdown#670

Merged
sbertix merged 3 commits into
supabitapp:mainfrom
panosAthDBX:fix-omp-presence-subagents
Jul 15, 2026
Merged

Fix OMP presence after subagent shutdown#670
sbertix merged 3 commits into
supabitapp:mainfrom
panosAthDBX:fix-omp-presence-subagents

Conversation

@panosAthDBX

Copy link
Copy Markdown
Contributor

Closes #669

Summary

  • keep OMP process presence alive when an in-process task subagent shuts down
  • map OMP session_shutdown to idle instead of session_end, leaving final cleanup to PID liveness and surface closure
  • add regression coverage that rejects session_end from the bundled OMP extension

OMP loads configured extensions into each in-process subagent session. Those sessions share the top-level OMP process PID and Supacode surface, so a subagent session_shutdown previously removed the main process presence record.

Type of change

  • Bug fix (the linked issue is a bug report)
  • Feature (the linked issue is a feature request marked ready)
  • Documentation
  • Other (please describe)

How was this tested?

  • make check passes (format + lint)
  • make test passes
  • I built and ran the app to confirm the change works

make build-app passes. The focused OmpSettingsInstallerTests invocation was attempted twice, but the test target currently fails during dependency compilation before tests execute because TCA's WritableKeyPath does not conform to Sendable under the installed toolchain.

The locally installed OMP extension was also updated with the same mapping for new OMP sessions.

AI tool disclosure (optional)

  • Model(s): OpenAI GPT-5.6 Sol
  • Harness / tools: Oh My Pi

Checklist

  • This pull request is linked to an issue with Closes # above.
  • For a feature, the linked issue is labeled ready.
  • I am the author of this work and accountable for it; no commit is authored or co-authored by an AI agent.
  • I have read the Contributing guide and the Code of Conduct.

@panosAthDBX
panosAthDBX force-pushed the fix-omp-presence-subagents branch from 0c1f4e2 to 9dd03c1 Compare July 14, 2026 16:31

@sbertix sbertix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you with this one (can't test it) 💪 thanks 🙇‍♂️

@sbertix
sbertix enabled auto-merge (squash) July 14, 2026 20:30
@sbertix
sbertix merged commit 9381328 into supabitapp:main Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OMP presence disappears when a task subagent shuts down

2 participants