This repository was archived by the owner on Sep 14, 2022. It is now read-only.
Fix conflict with swagger-node-runner 0.1.0#401
Open
sylwit wants to merge 1 commit intoswagger-api:masterfrom
Open
Fix conflict with swagger-node-runner 0.1.0#401sylwit wants to merge 1 commit intoswagger-api:masterfrom
sylwit wants to merge 1 commit intoswagger-api:masterfrom
Conversation
As it seems we can't upgrade swagger-node-runner to 0.6.0, here is a fix for a conflict between swagger-node and the runner You can't define a envvar starting by swagger_ because swagger-node is waiting for a value but the runner is waiting for a JSON.
Contributor
|
@sylwit can you see why the tests are failing with your PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it seems we can't upgrade swagger-node-runner to 0.6.0, here is a fix for a conflict between swagger-node and the runner
You can't define a envvar starting by swagger_ because swagger-node is waiting for a value but the runner is waiting for a JSON.