Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an externalized schema has an array property whose
itemsis a$refto another external file, and that is the only$refin the file, theitemsref is left as a raw relative path (./schemas/Item.yaml) instead of#/components/schemas/Item. It also stays unresolved withresolveFully.The second pass in
ComponentsProcessor.processSchemasonly reprocessed a model when one of its direct properties had a$ref, so a pending ref one level down (inside arrayitems) was skipped. It worked only when the same file also had a bare property$ref, which triggered a reprocess of the whole model.The second pass now reprocesses a model once when it has a pending external ref at any depth: properties,
items,additionalProperties,allOf/anyOf/oneOf,notand discriminator mapping. A visited set keeps the check safe on recursive schemas. This also stops the model from being reprocessed once per property with a$ref.Fixes: #2409
Type of Change
Checklist
Screenshots / Additional Context
Issue2409Testuses the reproduction from the issue plus two variants:entries), to show the property name is not a factorresolveFully, where the items schema is now inlinedThe full
swagger-parser-v3test suite passes on JDK 17 (700 tests).