feat: improve keystore connect dialog #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…react-hook-form for WalletKeystoreConnectDialog
Drakeoon
force-pushed
the
feat/improve-keystore-connect-dialog
branch
from
29b88a8 to
d8c445f
Compare
Drakeoon
changed the title
Drakeoon
changed the base branch from
develop
to
feat/improve-token-selection-ui-sorting-filtering
towanTG
approved these changes
Nov 18, 2025
towanTG
merged commit 1f93ab0
into
feat/improve-token-selection-ui-sorting-filtering
1 check passed
Drakeoon
added a commit
that referenced
this pull request
Nov 18, 2025
* fix: resolve missing dependencies issue, set exact=true in bunfig.toml * feat: set up the dialog components for keystore * feat: add tabs from shadcn/ui, improve dialog footer layout * feat: restore and refactor some of the keystore connect implementation * feat: add shadcn/ui components for implementing rich forms * feat: move keystore connection state outside of swapkit context, use react-hook-form for WalletKeystoreConnectDialog * feat: add loading states, move file input onChange handler outside of jsx * chore: reorder imports * feat: show new keystore connect dialog on keystore click * chore: remove old keystore dialog, remove dialog components outside of the scope * chore: update bun.lock * feat: tweak dialog styles to handle edge cases * feat: add missing variables, handle styling edge cases
towanTG
added a commit
that referenced
this pull request
Nov 19, 2025
…rategy (#1588) * feat: remove redundant code * fix: fix next playground build issues, add exact=true to bunfig * feat: implement improved token selection UI, rework balance calculation in swapkit context * feat: improve balance state calculation, improve wallet drawer ui * fix: fix hook after balance naming changes * feat: switch to built-in assetValue staticTokensMap, load tokens in the swapkit-context module * feat: add small optimisation for calculating filtered values * fix: fix createSwapKit sdk type errors * fix: fix swapkit ui type errors * chore: revert WalletConnectButton and keystore dialog changes * chore: apply changes after review * chore: revert type changes * fix: fix types * feat: improve keystore connect dialog (#1587) * fix: resolve missing dependencies issue, set exact=true in bunfig.toml * feat: set up the dialog components for keystore * feat: add tabs from shadcn/ui, improve dialog footer layout * feat: restore and refactor some of the keystore connect implementation * feat: add shadcn/ui components for implementing rich forms * feat: move keystore connection state outside of swapkit context, use react-hook-form for WalletKeystoreConnectDialog * feat: add loading states, move file input onChange handler outside of jsx * chore: reorder imports * feat: show new keystore connect dialog on keystore click * chore: remove old keystore dialog, remove dialog components outside of the scope * chore: update bun.lock * feat: tweak dialog styles to handle edge cases * feat: add missing variables, handle styling edge cases * feat: add v3 quote swap flow (#1590) * feat: remove redundant code * fix: fix next playground build issues, add exact=true to bunfig * feat: implement improved token selection UI, rework balance calculation in swapkit context * feat: improve balance state calculation, improve wallet drawer ui * fix: fix hook after balance naming changes * feat: switch to built-in assetValue staticTokensMap, load tokens in the swapkit-context module * feat: add small optimisation for calculating filtered values * fix: fix createSwapKit sdk type errors * fix: fix swapkit ui type errors * chore: revert WalletConnectButton and keystore dialog changes * chore: apply changes after review * chore: revert type changes * fix: fix types * fix: resolve missing dependencies issue, set exact=true in bunfig.toml * feat: set up the dialog components for keystore * feat: add tabs from shadcn/ui, improve dialog footer layout * feat: restore and refactor some of the keystore connect implementation * feat: add shadcn/ui components for implementing rich forms * feat: move keystore connection state outside of swapkit context, use react-hook-form for WalletKeystoreConnectDialog * feat: add loading states, move file input onChange handler outside of jsx * chore: reorder imports * feat: show new keystore connect dialog on keystore click * chore: remove old keystore dialog, remove dialog components outside of the scope * chore: update bun.lock * feat: tweak dialog styles to handle edge cases * feat: add missing variables, handle styling edge cases * feat: add setup for v3 quote and swap requets * feat: move into new way of overriding endpoints using SKConfig * feat: adjust swap flow to match API changes * chore: remove redundant code, fix smaller issues * feat: add simple localStorage form integration, remove custom apiKey field * feat: add `sk-ui-` prefix to widget's tailwindcss config, update @swapkit/ui to use prefixed classNames (#1591) * feat: update variables and tailwind config to use prefix * chore: replace tailwind classes in @swapkit/ui to match prefix * feat: set up sk-ui- prefix in tailwind config, disable preflight, update dependencies * feat: convert missing classNames to prefixed ones * chore: clean up assetValue static map export * chore: dirty fix ts issue tailwind.config.ts no in rootDir * chore: skip balance test --------- Co-authored-by: towan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
react-hook-formto@swapkit/uiswapkit-context, change balance-fetching strategyNote:
There are still 2 dialogs in progress:
Import phraseandCreate keystore. I'll align styles to match designs once we have them in placeconnect.keystore.dialog.mp4