Skip to content

Conversation

@sadielbartholomew
Copy link

Closes #705, plus add several extra words on the updated sentence to clarify the arguments to use to plt.plot which in my opinion is useful in addition and otherwise only implied i.e. to be picked up by assumption from the example code snippet - strictly a separate issue so added as a separate commit, but might as well raise in this PR (can revert if controversial but doubt it will be so!).

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Update the episode/lesson 'Plotting' to avoid use of the subjective term 'simple', by replacing with the more specific and objective assertion on conciseness, with (whilst touching that sentence) a very small amount of text added to clarify what arguments plt.plot takes.

If any relevant discussions have taken place elsewhere, please provide links to these.

n/a

@github-actions
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "just one call" -> "a single call"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - if 'just' is indeed a problematic word it is somewhat ironic, though unintentional, I ended up suggesting it in wording to replace use of 'simple'! Will update in a new commit in a moment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 1d882a2, though I'll let you mark this as formally resolved if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Plotting' lesson: avoid bad practice of stating 'X is simple'

2 participants