Rust timer example#4
Open
nebkor wants to merge 7 commits into
Open
Conversation
Doesn't actually run, though it does build and boot.
Error messages could be better, but at least you can have arbitrary expressions as the value argument to the macro.
proc_macros are required to have the function signature `pub fn(...)`, which means it can't be `pub unsafe fn(...)`. But they'll expand out to something that requires using `unsafe` at the call site, so at least users will be forced to face their life choices directly.
Collaborator
|
Still failing for me, I'm guessing I'm missing a weird path dependency because I still have all the necessary compiler packages installed to build the C stuff. |
Collaborator
Author
|
Well, telling bindgen to pretend to be an assembler didn't break anything, so if you can verify that works for you, call it good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, I think this branch is reasonably ready to merge into main, provided @dbt signs off on being able to build it on his system.