🍒 [lldb] Fix source line annotations for libsanitizers traces (#154247) #11798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) When providing allocation and deallocation traces, the ASan compiler-rt runtime already provides call addresses (`TracePCType::Calls`). On Darwin, system sanitizers (libsanitizers) provides return address. It also discards a few non-user frames at the top of the stack, because these internal libmalloc/libsanitizers stack frames do not provide any value when diagnosing memory errors. Introduce and add handling for `TracePCType::ReturnsNoZerothFrame` to cover this case and enable libsanitizers traces line-level testing. rdar://157596927 --- Commit 1 is a mechanical refactoring to introduce and adopt `TracePCType` enum to replace `pcs_are_call_addresses` bool. It preserve the current behavior: ``` pcs_are_call_addresses: false -> TracePCType::Returns (default) true -> TracePCType::Calls ``` Best reviewed commit by commit. (cherry picked from commit 484d040)
Author
|
@swift-ci Please test |
JDevlieghere
approved these changes
Nov 12, 2025
yln
deleted the
lldb-fix-source-line-annotations_cherry-pick_stable-21.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing allocation and deallocation traces, the ASan compiler-rt runtime already provides call addresses (
TracePCType::Calls).On Darwin, system sanitizers (libsanitizers)
provides return address. It also discards a few
non-user frames at the top of the stack, because
these internal libmalloc/libsanitizers stack
frames do not provide any value when diagnosing
memory errors.
Introduce and add handling for
TracePCType::ReturnsNoZerothFrameto cover thiscase and enable libsanitizers traces line-level
testing.
rdar://157596927
Commit 1 is a mechanical refactoring to introduce
and adopt
TracePCTypeenum to replacepcs_are_call_addressesbool. It preserve thecurrent behavior:
(cherry picked from commit 484d040)