refactor: make CJK-friendly emphasis opt-in by new parser option CMARK_OPT_CJK_FRIENDLY_EMPHASIS - #89
Closed
tats-u wants to merge 2 commits into
Closed
refactor: make CJK-friendly emphasis opt-in by new parser option CMARK_OPT_CJK_FRIENDLY_EMPHASIS#89tats-u wants to merge 2 commits into
CMARK_OPT_CJK_FRIENDLY_EMPHASIS#89tats-u wants to merge 2 commits into
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Author
|
Probably unneccessary: #78 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #86 (built on the top of it), but uses a new parser option
CMARK_OPT_CJK_FRIENDLY_EMPHASISinstead of the syntax extension"cjk_friendly_emphasis". Please choose one of them and let me know.Session (prompts are in Japanese): https://github.com/tats-u/cmark/tasks/90fc8fee-278e-47b6-96ee-9f5ccbb00a4b?session_id=e48b1af9-d532-4ae5-9754-211745c528f9
GPT-5.4 (initial) + Claude Haiku 4.5 (fix)
Also, strikethrough should also be CJK-friendly, too.
Note: this PR is targeting at #78, not
gfm.