Skip to content

Skip default CMO when emitting module separately #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjmansfield wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip default CMO when emitting module separately #2035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/SwiftDriver/Jobs/CompileJob.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,12 +296,14 @@ extension Driver {
forObject: outputType == .object)
try addRuntimeLibraryFlags(commandLine: &commandLine)

// Enable default cross-module optimization when possible, but only if we're not
// emitting the module separately (CMO is incompatible with separate module emission)
if Driver.canDoCrossModuleOptimization(parsedOptions: &parsedOptions) &&
// For historical reasons, -cross-module-optimization turns on "aggressive" CMO
// which is different from "default" CMO.
!parsedOptions.hasArgument(.CrossModuleOptimization) &&
!parsedOptions.hasArgument(.EnableCMOEverything) {
assert(!emitModuleSeparately, "Cannot emit module separately with cross-module-optimization")
!parsedOptions.hasArgument(.EnableCMOEverything) &&
!emitModuleSeparately {
commandLine.appendFlag("-enable-default-cmo")
}

Expand Down
Loading