[-debug-module-path] Prefer the moduleOutputInfo.output path if avail… #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able. While testing the LLDB support for enhanced module tracking I noticed that the driver currently always uses a relative path for -debug-module-path, which is an obvious problem when compiling in a different directory, or if the swift module output is in a different path than the object file output. This patch addresses this by preferring moduleOutputInfo.output if available. rdar://164524241 (Relanding with a relaxed test that doesn't encode the name of a temporary file) (cherry picked from commit 3999166)
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
This PR is identical to #2020 which I accidentally merged into |
owenv
approved these changes
Dec 3, 2025
nkcsgexi
approved these changes
Dec 3, 2025
artemcm
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able.
While testing the LLDB support for enhanced module tracking I noticed that the driver currently always uses a relative path for -debug-module-path, which is an obvious problem when compiling in a different directory, or if the swift module output is in a different path than the object file output. This patch addresses this by preferring moduleOutputInfo.output if available.
rdar://164524241
(Relanding with a relaxed test that doesn't encode the name of a temporary file)
(cherry picked from commit 3999166)
Explanation: use absolute paths for -debug-module-path when possible
Scope: Debug Info for EBM builds
Issues: rdar://164524241
Original PRs: #2004
Risk: Low
Testing: Unit test
Reviewers: @owenv