Conversation
Signed-off-by: dzdidi <dzdidi@protonmail.com>
Signed-off-by: dzdidi <dzdidi@protonmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request migrates the configuration file format from JSON to TOML and adds two new delay configuration options for the probing feature. The migration improves configuration readability while maintaining backward compatibility through serde defaults.
Changes:
- Migrated configuration format from
config.jsontoconfig.tomlthroughout the codebase - Added
probe_delay_secandpeer_delay_secconfiguration fields to control timing between probes and peers - Implemented delay logic in the probing functionality to rate-limit probe requests
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/config.rs | Updated to parse TOML format instead of JSON; added two new delay configuration fields with default values (1s and 2s) |
| src/main.rs | Implemented probe and peer delay logic in the probing loop; updated warning messages to reference config.toml |
| src/cli.rs | Added probe_delay_sec and peer_delay_sec fields to ProbingConfig struct; updated comment to reference config.toml |
| src/args.rs | Updated usage message to reference config.toml instead of config.json |
| Cargo.toml | Added toml crate dependency version 0.8 |
| Cargo.lock | Lock file updates for toml crate and its dependencies (serde_spanned, toml_datetime, toml_edit, toml_write, winnow) |
| config.example.toml | New TOML example configuration file with all fields including new delay settings |
| config.example.json | Removed JSON example configuration file |
| README.md | Updated documentation to reference TOML format throughout and replaced JSON example with TOML syntax |
| prober_config.json.example | Added probe_delay_sec and peer_delay_sec fields to example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [probing] | ||
| interval_sec = 300 | ||
| peers = ["02abc123...@1.2.3.4:9735"] | ||
| amount_msats = [1000, 10000, 100000, 1000000] | ||
| timeout_sec = 60 | ||
| ``` |
There was a problem hiding this comment.
The probing configuration example is missing the new probe_delay_sec and peer_delay_sec fields that were added in this PR. These fields should be included in the example for completeness and consistency with the other example configurations (config.example.toml and the help text in src/config.rs).
Signed-off-by: dzdidi <dzdidi@protonmail.com>
Blocked by / Based on #5