Don't discard ordering of include/exclude entries in KernelModules= #4016
Conversation
Since eecf8b3 `KernelModules=` supports both inclusion and exclusion of kmods. When resolving kmod presets like "default" and "host" (and perhaps others in the future) it's important to retain the ordering of entries, so that the user can add a preset and then subtract only specific modules from the working set. `filter_kernel_modules` relies on this ordering to do its job.
LaurenceKiln
force-pushed
the
keep_kmod_ordering
branch
from
6df461e to
05f3986
Compare
|
@DaanDeMeyer , I noticed that when you merge PRs the original commit message is lost and there's also no reference to the Issue/PR. Is this deliberate? Should I just skip the commit messages? |
I just press merge when > 1 commit or rebase when 1 commit, same policy as in systemd. No clue what github does under the hood |
|
Looks like "Rebase and merge" will not add a link to the PR, possibly because the rebase changes the commit hashes. That's idiotic. |
LaurenceKiln
force-pushed
the
keep_kmod_ordering
branch
from
331ea57 to
bcd0b2e
Compare
|
@LaurenceKiln Please amend commits instead of pushing updates. We want to merge perfect commits and I don't have the muscle memory to remember I need to squash yours. |
|
understood. not too late to force-push a correction. |
People frown upon it so I don't do it, I also hope we have branch protection on. Also, massive thanks for all the quality contributions! Great to see someone picking up the pace as I haven't been doing too much lately. |
|
Thanks for the kudos. I came across the project it and it just grabbed me. |
3 participants
Since eecf8b3
KernelModules=supports both inclusion and exclusion of kmods. When resolving kmod presets like "default" and "host" (and perhaps others in the future) it's important to retain the ordering of entries, so that the user can add a preset and then subtract only specific modules from the working set.filter_kernel_modulesrelies on this ordering to do its job.