Conversation
mvo5
force-pushed
the
auth-api-keys
branch
2 times, most recently
from
August 13, 2026 06:55
1b4699e to
a06717f
Compare
mvo5
marked this pull request as ready for review
September 10, 2026 15:57
katexochen
reviewed
Sep 11, 2026
katexochen
reviewed
Sep 11, 2026
This is the most simple form of authentication. Plain api keys that can be used trivially with e.g. curl to run authenticated calls against varlink-httpd.
Some files must not be readable by others, e.g. the client's api-key
file is a bearer secret. Add secret_file::{check,read}_secret_file()
and use them for the api-key file and the generated TLS server key,
replacing the inline mode check.
read_secret_file() checks the mode on the opened handle so the file
that was checked is the file that is read. The api-key file allows
group access so a root-owned copy under /etc can be shared with a
dedicated group; the TLS key stays owner-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most simple form of authentication. Plain api
keys that can be used trivially with e.g. curl to run
authenticated calls against varlink-httpd.