Conversation
SELECT aliases used inside HAVING were reported as "Unknown column" and were not offered by completion, even though MySQL allows alias references in HAVING just like in ORDER BY/GROUP BY. The shared alias-visibility context only recognized ORDER BY/GROUP BY and excluded any segment containing HAVING, so a query such as SELECT COUNT(*) AS cnt, g FROM t GROUP BY g HAVING cnt > 1 flagged cnt. Include HAVING in the alias-visible context so diagnostics stay aligned with executable MySQL semantics and alias completion appears there. Fixes t8y2#8713
SQL Server cloned a table with SELECT TOP 0 * INTO, which copies columns and the IDENTITY property but drops every constraint. A cloned table therefore silently lost its primary key while keeping the identity marker, which made the loss easy to miss and broke data copies that expect the key (t8y2#8931). Load the source primary key before cloning and let the DDL builder append ALTER TABLE ... ADD CONSTRAINT ... PRIMARY KEY after the SELECT INTO, executed as a script. Clones without a primary key keep the previous single-statement path. Fixes t8y2#8931
The custom WebKit scrollbar styling on the query editor scroller only set width, so the horizontal scrollbar kept the default thickness while the rounded thumb styling made it stand out. It also reserves editor space permanently. Set height to the same 5px so both axes match. Fixes t8y2#8920
github-actions
Bot
added
area/core
Closed
Owner
|
Hi @dienaso, thanks for the report and the patch! Unfortunately this particular fix has already landed: PR #8941 added the same To be clear, nothing of yours is lost: your HAVING alias fix was already merged via #8953, and the SQL Server clone primary-key fix is under review in #8954. Feel free to rebase that branch if needed, and thanks again for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8920
问题 / Problem
查询编辑器对
.cm-scroller自定义了 WebKit 滚动条样式，但只设置了width: 5px（纵向），漏掉了横向的height。后果：::-webkit-scrollbar，WebKit 不再对该滚动容器使用 macOS overlay 自动隐藏，粗滚动条还会永久占据编辑器底部空间；border-radius: 999px的灰色 thumb 样式两轴共用，粗横向条在视觉上格外突兀。修复 / Fix
::-webkit-scrollbar规则补充height: 5px，横向滚动条与纵向保持一致的 5px 细条（scrollbar-width: thin的 Firefox 回退路径本就两轴生效，无需改动）。测试 / Tests
纯 CSS 修复：与 issue 截图对照，在纵向滚动条已有 5px 样式的编辑器中，横向滚动条随之变细并停止占用额外空间。现有 vitest / vue-tsc 不受影响。